OSDN Git Service

clk: sunxi: avoid double DT matching
authorRob Herring <robh@kernel.org>
Mon, 12 May 2014 16:24:31 +0000 (11:24 -0500)
committerRob Herring <robh@kernel.org>
Tue, 20 May 2014 19:25:22 +0000 (14:25 -0500)
Use for_each_matching_node_and_match instead of for_each_matching_node plus
of_match_node to avoid searching the DT twice for each node.

The sunxi DT scanning code should really be re-worked rather than have
its own private matching infrastructure. It is working around needing a
function pointer and a data pointer for each compatible match.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: "Emilio López" <emilio@elopez.com.ar>
Acked-by: Mike Turquette <mturquette@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
drivers/clk/sunxi/clk-sunxi.c

index bd7dc73..ef5e2d8 100644 (file)
@@ -1278,8 +1278,7 @@ static void __init of_sunxi_table_clock_setup(const struct of_device_id *clk_mat
        const struct of_device_id *match;
        void (*setup_function)(struct device_node *, const void *) = function;
 
-       for_each_matching_node(np, clk_match) {
-               match = of_match_node(clk_match, np);
+       for_each_matching_node_and_match(np, clk_match, &match) {
                data = match->data;
                setup_function(np, data);
        }