OSDN Git Service

iris: Drop comment about var->data.binding not being set.
authorKenneth Graunke <kenneth@whitecape.org>
Sun, 7 Jul 2019 23:58:14 +0000 (16:58 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 11 Jul 2019 07:12:00 +0000 (00:12 -0700)
I refactored the sampler lowering passes a long time ago to ensure
that gl_nir_lower_samplers_as_deref is run and var->data.binding is set.

src/gallium/drivers/iris/iris_program.c

index 642d932..2fe842e 100644 (file)
@@ -364,10 +364,6 @@ iris_setup_uniforms(const struct brw_compiler *compiler,
             nir_deref_instr *deref = nir_src_as_deref(intrin->src[0]);
             nir_variable *var = nir_deref_instr_get_variable(deref);
 
-            /* XXX: var->data.binding is not set properly.  We need to run
-             * some form of gl_nir_lower_samplers_as_deref() to get it.
-             * This breaks tests which use more than one image.
-             */
             if (img_idx[var->data.binding] == -1) {
                /* GL only allows arrays of arrays of images. */
                assert(glsl_type_is_image(glsl_without_array(var->type)));