OSDN Git Service

memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
authorGaosheng Cui <cuigaosheng1@huawei.com>
Sat, 26 Nov 2022 04:49:11 +0000 (12:49 +0800)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 27 Dec 2022 08:54:32 +0000 (09:54 +0100)
The clk_disable_unprepare() should be called in the error handling
of devbus_get_timing_params() and of_platform_populate(), fix it by
replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled.

Fixes: e81b6abebc87 ("memory: add a driver for atmel ram controllers")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221126044911.7226-1-cuigaosheng1@huawei.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/memory/mvebu-devbus.c

index 8450638..efc6c08 100644 (file)
@@ -280,10 +280,9 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
        if (IS_ERR(devbus->base))
                return PTR_ERR(devbus->base);
 
-       clk = devm_clk_get(&pdev->dev, NULL);
+       clk = devm_clk_get_enabled(&pdev->dev, NULL);
        if (IS_ERR(clk))
                return PTR_ERR(clk);
-       clk_prepare_enable(clk);
 
        /*
         * Obtain clock period in picoseconds,