OSDN Git Service

mfd: intel-lpss: Consistently use GENMASK()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 16 Aug 2019 17:33:42 +0000 (20:33 +0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 2 Sep 2019 10:09:03 +0000 (11:09 +0100)
Since we already are using BIT() macro, use GENMASK() as well for sake of
consistency.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/intel-lpss.c

index 277f48f..3e16a17 100644 (file)
 #define LPSS_PRIV_IDLELTR              0x14
 
 #define LPSS_PRIV_LTR_REQ              BIT(15)
-#define LPSS_PRIV_LTR_SCALE_MASK       0xc00
-#define LPSS_PRIV_LTR_SCALE_1US                0x800
-#define LPSS_PRIV_LTR_SCALE_32US       0xc00
-#define LPSS_PRIV_LTR_VALUE_MASK       0x3ff
+#define LPSS_PRIV_LTR_SCALE_MASK       GENMASK(11, 10)
+#define LPSS_PRIV_LTR_SCALE_1US                (2 << 10)
+#define LPSS_PRIV_LTR_SCALE_32US       (3 << 10)
+#define LPSS_PRIV_LTR_VALUE_MASK       GENMASK(9, 0)
 
 #define LPSS_PRIV_SSP_REG              0x20
 #define LPSS_PRIV_SSP_REG_DIS_DMA_FIN  BIT(0)
@@ -59,8 +59,8 @@
 
 #define LPSS_PRIV_CAPS                 0xfc
 #define LPSS_PRIV_CAPS_NO_IDMA         BIT(8)
+#define LPSS_PRIV_CAPS_TYPE_MASK       GENMASK(7, 4)
 #define LPSS_PRIV_CAPS_TYPE_SHIFT      4
-#define LPSS_PRIV_CAPS_TYPE_MASK       (0xf << LPSS_PRIV_CAPS_TYPE_SHIFT)
 
 /* This matches the type field in CAPS register */
 enum intel_lpss_dev_type {