OSDN Git Service

ASoC: codecs: ak4458: Remove set but never checked variable 'ret'
authorLee Jones <lee.jones@linaro.org>
Thu, 9 Jul 2020 16:23:27 +0000 (11:23 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 10 Jul 2020 14:13:52 +0000 (15:13 +0100)
Looks as though the result of snd_soc_update_bits() has never been checked.

Fixes the following W=1 kernel build warning(s):

sound/soc/codecs/ak4458.c: In function ‘ak4458_set_dai_mute’:
sound/soc/codecs/ak4458.c:408:16: warning: variable ‘ret’ set but not
used [-Wunused-but-set-variable]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>
Cc: Mihai Serban <mihai.serban@nxp.com>
Link: https://lore.kernel.org/r/20200709162328.259586-11-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/ak4458.c

index f180cb5..39ae089 100644 (file)
@@ -405,7 +405,7 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute)
 {
        struct snd_soc_component *component = dai->component;
        struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component);
-       int nfs, ndt, ret, reg;
+       int nfs, ndt, reg;
        int ats;
 
        nfs = ak4458->fs;
@@ -416,14 +416,14 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute)
        ndt = att_speed[ats] / (nfs / 1000);
 
        if (mute) {
-               ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2,  0x01, 1);
+               snd_soc_component_update_bits(component, AK4458_01_CONTROL2,  0x01, 1);
                mdelay(ndt);
                if (ak4458->mute_gpiod)
                        gpiod_set_value_cansleep(ak4458->mute_gpiod, 1);
        } else {
                if (ak4458->mute_gpiod)
                        gpiod_set_value_cansleep(ak4458->mute_gpiod, 0);
-               ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0);
+               snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0);
                mdelay(ndt);
        }