2009-10-08 Paul Pluzhnikov <ppluzhnikov@google.com>

	PR gdb/10457
	* elfread.c (elf_symtab_read): Don't use alloca in a loop.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b807c85..744bf7c 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2009-10-08  Paul Pluzhnikov  <ppluzhnikov@google.com>
+
+       PR gdb/10457
+       * elfread.c (elf_symtab_read): Don't use alloca in a loop.
+       
 2009-10-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
        * i386-nat.c (i386_stopped_by_hwbp): Remove.

diff --git a/gdb/elfread.c b/gdb/elfread.c
index 6e79d4a..767dfe6 100644 (file)
--- a/gdb/elfread.c
+++ b/gdb/elfread.c
@@ -535,7 +535,7 @@ elf_symtab_read (struct objfile *objfile, int type,
 
              if (len > 4 && strcmp (sym->name + len - 4, "@plt") == 0)
                {
-                 char *base_name = alloca (len - 4 + 1);
+                 char *base_name = xmalloc (len - 4 + 1);
                  struct minimal_symbol *mtramp;
 
                  memcpy (base_name, sym->name, len - 4);
@@ -543,6 +543,7 @@ elf_symtab_read (struct objfile *objfile, int type,
                  mtramp = record_minimal_symbol (base_name, symaddr,
                                                  mst_solib_trampoline,
                                                  sym->section, objfile);
+                 xfree (base_name);
                  if (mtramp)
                    {
                      MSYMBOL_SIZE (mtramp) = MSYMBOL_SIZE (msym);