OSDN Git Service

watchdog: qcom: Use irq flags from firmware
authorStephen Boyd <swboyd@chromium.org>
Thu, 20 Feb 2020 00:20:47 +0000 (16:20 -0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Wed, 18 Mar 2020 10:15:22 +0000 (11:15 +0100)
The DT or ACPI tables should tell the driver what the irq flags are.
Given that this driver probes only on DT based platforms and those DT
platforms specify the irq flags we can safely drop the forced irq flag
setting here.

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Link: https://lore.kernel.org/r/20200220002047.115000-1-swboyd@chromium.org
[groeck: Context conflict resolution]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/qcom-wdt.c

index 460967a..ab7465d 100644 (file)
@@ -263,8 +263,7 @@ static int qcom_wdt_probe(struct platform_device *pdev)
        /* check if there is pretimeout support */
        irq = platform_get_irq_optional(pdev, 0);
        if (data->pretimeout && irq > 0) {
-               ret = devm_request_irq(dev, irq, qcom_wdt_isr,
-                                      IRQF_TRIGGER_RISING,
+               ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0,
                                       "wdt_bark", &wdt->wdd);
                if (ret)
                        return ret;