OSDN Git Service

crypto: inside-secure - fix queued len computation
authorAntoine Tenart <antoine.tenart@bootlin.com>
Mon, 27 May 2019 14:51:02 +0000 (16:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 6 Jun 2019 06:38:56 +0000 (14:38 +0800)
This patch fixes the queued len computation, which could theoretically
be wrong if req->len[1] - req->processed[1] > 1. Be future-proof here,
and fix it.

Fixes: b460edb6230a ("crypto: inside-secure - sha512 support")
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/inside-secure/safexcel_hash.c

index ba0732f..a9197d2 100644 (file)
@@ -50,10 +50,12 @@ struct safexcel_ahash_req {
 
 static inline u64 safexcel_queued_len(struct safexcel_ahash_req *req)
 {
-       if (req->len[1] > req->processed[1])
-               return 0xffffffff - (req->len[0] - req->processed[0]);
+       u64 len, processed;
 
-       return req->len[0] - req->processed[0];
+       len = (0xffffffff * req->len[1]) + req->len[0];
+       processed = (0xffffffff * req->processed[1]) + req->processed[0];
+
+       return len - processed;
 }
 
 static void safexcel_hash_token(struct safexcel_command_desc *cdesc,