OSDN Git Service

kvm: x86: Drop redundant apic base and tpr update from kvm_get_sregs
authorJan Kiszka <jan.kiszka@siemens.com>
Wed, 26 Oct 2011 11:09:45 +0000 (13:09 +0200)
committerMarcelo Tosatti <mtosatti@redhat.com>
Thu, 22 Dec 2011 16:53:01 +0000 (14:53 -0200)
The latter was already commented out, the former is redundant as well.
We always get the latest changes after return from the guest via
kvm_arch_post_run.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
target-i386/kvm.c

index 06f4401..d206852 100644 (file)
@@ -1082,10 +1082,9 @@ static int kvm_get_sregs(CPUState *env)
     env->cr[3] = sregs.cr3;
     env->cr[4] = sregs.cr4;
 
-    cpu_set_apic_base(env->apic_state, sregs.apic_base);
-
     env->efer = sregs.efer;
-    //cpu_set_apic_tpr(env->apic_state, sregs.cr8);
+
+    /* changes to apic base and cr8/tpr are read back via kvm_arch_post_run */
 
 #define HFLAG_COPY_MASK \
     ~( HF_CPL_MASK | HF_PE_MASK | HF_MP_MASK | HF_EM_MASK | \