OSDN Git Service

drm/amdgpu/display: make backlight setting failure messages debug
authorAlex Deucher <alexander.deucher@amd.com>
Fri, 21 May 2021 04:03:17 +0000 (00:03 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 21 May 2021 22:02:53 +0000 (18:02 -0400)
Avoid spamming the log.  The backlight controller on DCN chips
gets powered down when the display is off, so if you attempt to
set the backlight level when the display is off, you'll get this
message.  This isn't a problem as we cache the requested backlight
level if it's adjusted when the display is off and set it again
during modeset.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: nicholas.choi@amd.com
Cc: harry.wentland@amd.com
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index e0c727c..f303e8d 100644 (file)
@@ -3506,7 +3506,7 @@ static int amdgpu_dm_backlight_set_level(struct amdgpu_display_manager *dm,
                        rc = dc_link_set_backlight_level_nits(link[i], true, brightness[i],
                                AUX_BL_DEFAULT_TRANSITION_TIME_MS);
                        if (!rc) {
-                               DRM_ERROR("DM: Failed to update backlight via AUX on eDP[%d]\n", i);
+                               DRM_DEBUG("DM: Failed to update backlight via AUX on eDP[%d]\n", i);
                                break;
                        }
                }
@@ -3514,7 +3514,7 @@ static int amdgpu_dm_backlight_set_level(struct amdgpu_display_manager *dm,
                for (i = 0; i < dm->num_of_edps; i++) {
                        rc = dc_link_set_backlight_level(dm->backlight_link[i], brightness[i], 0);
                        if (!rc) {
-                               DRM_ERROR("DM: Failed to update backlight on eDP[%d]\n", i);
+                               DRM_DEBUG("DM: Failed to update backlight on eDP[%d]\n", i);
                                break;
                        }
                }