OSDN Git Service

scsi: NCR5380: Remove the NCR5380_CMD_SIZE macro
authorBart Van Assche <bvanassche@acm.org>
Fri, 18 Feb 2022 19:50:35 +0000 (11:50 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Feb 2022 02:11:03 +0000 (21:11 -0500)
This makes it easier to find users of the NCR5380_cmd data structure with
'grep'.

Link: https://lore.kernel.org/r/20220218195117.25689-8-bvanassche@acm.org
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Ondrej Zary <linux@rainbow-software.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Acked-by: Finn Thain <fthain@linux-m68k.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/NCR5380.h
drivers/scsi/arm/cumana_1.c
drivers/scsi/arm/oak.c
drivers/scsi/atari_scsi.c
drivers/scsi/dmx3191d.c
drivers/scsi/g_NCR5380.c
drivers/scsi/mac_scsi.c
drivers/scsi/sun3_scsi.c

index 8a3b419..845bd24 100644 (file)
@@ -230,8 +230,6 @@ struct NCR5380_cmd {
        struct list_head list;
 };
 
-#define NCR5380_CMD_SIZE               (sizeof(struct NCR5380_cmd))
-
 #define NCR5380_PIO_CHUNK_SIZE         256
 
 /* Time limit (ms) to poll registers when IRQs are disabled, e.g. during PDMA */
index 3fd9443..5d4f67b 100644 (file)
@@ -223,7 +223,7 @@ static struct scsi_host_template cumanascsi_template = {
        .sg_tablesize           = SG_ALL,
        .cmd_per_lun            = 2,
        .proc_name              = "CumanaSCSI-1",
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
        .max_sectors            = 128,
        .dma_boundary           = PAGE_SIZE - 1,
 };
index 78f33d5..f18a062 100644 (file)
@@ -113,7 +113,7 @@ static struct scsi_host_template oakscsi_template = {
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
        .proc_name              = "oakscsi",
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
        .max_sectors            = 128,
 };
 
index 95d7a35..e9d0d99 100644 (file)
@@ -711,7 +711,7 @@ static struct scsi_host_template atari_scsi_template = {
        .this_id                = 7,
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
 };
 
 static int __init atari_scsi_probe(struct platform_device *pdev)
index 6df60b3..a171ce6 100644 (file)
@@ -52,7 +52,7 @@ static struct scsi_host_template dmx3191d_driver_template = {
        .sg_tablesize           = SG_ALL,
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
 };
 
 static int dmx3191d_probe_one(struct pci_dev *pdev,
index 7ba3c93..5923f86 100644 (file)
@@ -702,7 +702,7 @@ static struct scsi_host_template driver_template = {
        .sg_tablesize           = SG_ALL,
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
        .max_sectors            = 128,
 };
 
index 5c808fb..71d493a 100644 (file)
@@ -434,7 +434,7 @@ static struct scsi_host_template mac_scsi_template = {
        .sg_tablesize           = 1,
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
        .max_sectors            = 128,
 };
 
index f7f724a..82a2532 100644 (file)
@@ -505,7 +505,7 @@ static struct scsi_host_template sun3_scsi_template = {
        .sg_tablesize           = 1,
        .cmd_per_lun            = 2,
        .dma_boundary           = PAGE_SIZE - 1,
-       .cmd_size               = NCR5380_CMD_SIZE,
+       .cmd_size               = sizeof(struct NCR5380_cmd),
 };
 
 static int __init sun3_scsi_probe(struct platform_device *pdev)