OSDN Git Service

nouveau: don't touch NV_USER regs on channel destroy.
authorBen Skeggs <skeggsb@gmail.com>
Fri, 7 Mar 2008 03:38:05 +0000 (14:38 +1100)
committerBen Skeggs <skeggsb@gmail.com>
Fri, 7 Mar 2008 04:18:34 +0000 (15:18 +1100)
Not only was this entirely pointless, it actually causes my NV30GL to
die randomly when channels are destroyed.

shared-core/nouveau_fifo.c

index 056cb6d..8e93207 100644 (file)
@@ -433,13 +433,6 @@ void nouveau_fifo_free(struct nouveau_channel *chan)
        NV_WRITE(NV03_PFIFO_CACHE1_PUSH0, 0x00000000);
        NV_WRITE(NV04_PFIFO_CACHE1_PULL0, 0x00000000);
 
-       /* stop the fifo, otherwise it could be running and
-        * it will crash when removing gpu objects
-        *XXX: from real-world evidence, absolutely useless..
-        */
-       NV_WRITE(chan->get, chan->pushbuf_base);
-       NV_WRITE(chan->put, chan->pushbuf_base);
-
        // FIXME XXX needs more code
 
        engine->fifo.destroy_context(chan);