OSDN Git Service

net/fungible: Fix local_memory_node error
authorDimitris Michailidis <d.michailidis@fungible.com>
Tue, 8 Mar 2022 04:53:21 +0000 (20:53 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Mar 2022 11:26:07 +0000 (11:26 +0000)
Stephen Rothwell reported the following failure on powerpc:

ERROR: modpost: ".local_memory_node"
[drivers/net/ethernet/fungible/funeth/funeth.ko] undefined!

AFAICS this is because local_memory_node() is a non-inline non-exported
function when CONFIG_HAVE_MEMORYLESS_NODES=y. It is also the wrong API
to get a CPU's memory node. Use cpu_to_mem() in the two spots it's used.

Fixes: ee6373ddf3a9 ("net/funeth: probing and netdev ops")
Fixes: db37bc177dae ("net/funeth: add the data path")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/fungible/funeth/funeth_main.c
drivers/net/ethernet/fungible/funeth/funeth_txrx.h

index c58b10c..67dd02e 100644 (file)
@@ -253,7 +253,7 @@ static struct fun_irq *fun_alloc_qirq(struct funeth_priv *fp, unsigned int idx,
        int cpu, res;
 
        cpu = cpumask_local_spread(idx, node);
-       node = local_memory_node(cpu_to_node(cpu));
+       node = cpu_to_mem(cpu);
 
        irq = kzalloc_node(sizeof(*irq), GFP_KERNEL, node);
        if (!irq)
index 7aed056..04c9f91 100644 (file)
@@ -239,7 +239,7 @@ static inline void fun_txq_wr_db(const struct funeth_txq *q)
 
 static inline int fun_irq_node(const struct fun_irq *p)
 {
-       return local_memory_node(cpu_to_node(cpumask_first(&p->affinity_mask)));
+       return cpu_to_mem(cpumask_first(&p->affinity_mask));
 }
 
 int fun_rxq_napi_poll(struct napi_struct *napi, int budget);