OSDN Git Service

RDMA/core: Delete BUG() from unreachable flow
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 17 Aug 2017 12:50:38 +0000 (15:50 +0300)
committerDoug Ledford <dledford@redhat.com>
Thu, 24 Aug 2017 20:27:10 +0000 (16:27 -0400)
Remove call to BUG() in case wrong node_type was provided.
This flow is unreachable, because node_types are supplied
from specific enum.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/verbs.c

index 6a7cbc1..4c1485e 100644 (file)
@@ -180,21 +180,15 @@ EXPORT_SYMBOL(ib_rate_to_mbps);
 __attribute_const__ enum rdma_transport_type
 rdma_node_get_transport(enum rdma_node_type node_type)
 {
-       switch (node_type) {
-       case RDMA_NODE_IB_CA:
-       case RDMA_NODE_IB_SWITCH:
-       case RDMA_NODE_IB_ROUTER:
-               return RDMA_TRANSPORT_IB;
-       case RDMA_NODE_RNIC:
-               return RDMA_TRANSPORT_IWARP;
-       case RDMA_NODE_USNIC:
+
+       if (node_type == RDMA_NODE_USNIC)
                return RDMA_TRANSPORT_USNIC;
-       case RDMA_NODE_USNIC_UDP:
+       if (node_type == RDMA_NODE_USNIC_UDP)
                return RDMA_TRANSPORT_USNIC_UDP;
-       default:
-               BUG();
-               return 0;
-       }
+       if (node_type == RDMA_NODE_RNIC)
+               return RDMA_TRANSPORT_IWARP;
+
+       return RDMA_TRANSPORT_IB;
 }
 EXPORT_SYMBOL(rdma_node_get_transport);