OSDN Git Service

mt76: mt7615: hold mt76 lock queueing wd in mt7615_queue_key_update
authorLorenzo Bianconi <lorenzo@kernel.org>
Thu, 30 Jul 2020 09:21:31 +0000 (11:21 +0200)
committerFelix Fietkau <nbd@nbd.name>
Thu, 24 Sep 2020 16:10:12 +0000 (18:10 +0200)
wq queue is always updated holding mt76 spinlock. Grab mt76 lock in
mt7615_queue_key_update() before putting a new element at the end of the
queue.

Fixes: eb99cc95c3b65 ("mt76: mt7615: introduce mt7663u support")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/main.c

index 2d0b1f4..bafe2bd 100644 (file)
@@ -361,7 +361,10 @@ mt7615_queue_key_update(struct mt7615_dev *dev, enum set_key_cmd cmd,
        wd->key.keylen = key->keylen;
        wd->key.cmd = cmd;
 
+       spin_lock_bh(&dev->mt76.lock);
        list_add_tail(&wd->node, &dev->wd_head);
+       spin_unlock_bh(&dev->mt76.lock);
+
        queue_work(dev->mt76.wq, &dev->wtbl_work);
 
        return 0;