OSDN Git Service

scsi: megaraid_sas: remove set but not used variables 'buff_addr' and 'ci_h'
authorYueHaibing <yuehaibing@huawei.com>
Sat, 25 May 2019 12:40:06 +0000 (20:40 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 18 Jun 2019 23:46:25 +0000 (19:46 -0400)
Fixes gcc '-Wunused-but-set-variable' warnings:

drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_fw_crash_buffer_show:
drivers/scsi/megaraid/megaraid_sas_base.c:3138:16: warning: variable buff_addr set but not used [-Wunused-but-set-variable]
drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_get_pd_list:
drivers/scsi/megaraid/megaraid_sas_base.c:4426:13: warning: variable ci_h set but not used [-Wunused-but-set-variable]

'buff_addr' is never used since inroduction in commit fc62b3fc9021
("megaraid_sas : Firmware crash dump feature support")

'ci_h' is not used since commit 9b3d028f3468 ("scsi: megaraid_sas:
Pre-allocate frequently used DMA buffers")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c

index f8d851f..46effaa 100644 (file)
@@ -3147,7 +3147,6 @@ megasas_fw_crash_buffer_show(struct device *cdev,
        struct megasas_instance *instance =
                (struct megasas_instance *) shost->hostdata;
        u32 size;
-       unsigned long buff_addr;
        unsigned long dmachunk = CRASH_DMA_BUF_SIZE;
        unsigned long src_addr;
        unsigned long flags;
@@ -3164,8 +3163,6 @@ megasas_fw_crash_buffer_show(struct device *cdev,
                return -EINVAL;
        }
 
-       buff_addr = (unsigned long) buf;
-
        if (buff_offset > (instance->fw_crash_buffer_size * dmachunk)) {
                dev_err(&instance->pdev->dev,
                        "Firmware crash dump offset is out of range\n");
@@ -4413,7 +4410,6 @@ megasas_get_pd_list(struct megasas_instance *instance)
        struct megasas_dcmd_frame *dcmd;
        struct MR_PD_LIST *ci;
        struct MR_PD_ADDRESS *pd_addr;
-       dma_addr_t ci_h = 0;
 
        if (instance->pd_list_not_supported) {
                dev_info(&instance->pdev->dev, "MR_DCMD_PD_LIST_QUERY "
@@ -4422,7 +4418,6 @@ megasas_get_pd_list(struct megasas_instance *instance)
        }
 
        ci = instance->pd_list_buf;
-       ci_h = instance->pd_list_buf_h;
 
        cmd = megasas_get_cmd(instance);