This fixes the build to always define the ANDROID macro, and remove an empty -I from...

The latter had the effect of removing the benefit of optimization settings, i.e. a typical compiler
command would look like:

   <toolchain-compiler> .... -Isources/<module-path> -I -O2 -g

The "-I -O2" was interpreted literally as "search in '-O2' directory, and the optimization was
never set to 2 (or 0 in case of debug mode).

diff --git a/build/core/build-binary.mk b/build/core/build-binary.mk
index 6566fec..1446a7d 100644 (file)
--- a/build/core/build-binary.mk
+++ b/build/core/build-binary.mk
@@ -29,6 +29,10 @@ include $(BUILD_SYSTEM)/build-module.mk
 # list of generated object files
 LOCAL_OBJECTS :=
 
+# always define ANDROID when building binaries
+#
+LOCAL_CFLAGS := -DANDROID $(LOCAL_CFLAGS)
+
 #
 # Add the default system shared libraries to the build
 #

diff --git a/build/core/definitions.mk b/build/core/definitions.mk
index 4135faa..1a425de 100644 (file)
--- a/build/core/definitions.mk
+++ b/build/core/definitions.mk
@@ -370,7 +370,6 @@ $$(_OBJ): PRIVATE_CC       := $$($$(my)CC)
 $$(_OBJ): PRIVATE_CFLAGS   := $$($$(my)CFLAGS) \
                               $$($$(my)_$(LOCAL_ARM_MODE)_$(LOCAL_BUILD_MODE)_CFLAGS) \
                               -I$$(LOCAL_PATH) \
-                              -I$$(OBJS_DIR)   \
                               $$(LOCAL_CFLAGS) \
                               $$(NDK_APP_CPPFLAGS) \
                               $$(NDK_APP_CFLAGS) \
@@ -430,7 +429,6 @@ $$(_OBJ): PRIVATE_CXX      := $$($$(my)CXX)
 $$(_OBJ): PRIVATE_CXXFLAGS := $$($$(my)CXXFLAGS) \
                               $$($$(my)_$(LOCAL_ARM_MODE)_$(LOCAL_BUILD_MODE)_CFLAGS) \
                               -I$$(LOCAL_PATH) \
-                              -I$$(OBJS_DIR)   \
                               $$(LOCAL_CFLAGS) \
                               $$(NDK_APP_CPPFLAGS) \
                               $$(NDK_APP_CXXFLAGS) \