OSDN Git Service

scsi: message: fusion: Remove unused variable retval
authorAlexander Vorwerk <alexander.vorwerk@stud.uni-goettingen.de>
Thu, 17 Mar 2022 03:03:25 +0000 (04:03 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 Apr 2022 03:26:32 +0000 (23:26 -0400)
The following warning showed up when compiling with W=1.

drivers/message/fusion/mptctl.c: In function ‘mptctl_hp_hostinfo’:
drivers/message/fusion/mptctl.c:2337:8: warning: variable ‘retval’ set but not used [-Wunused-but-set-variable]
  int   retval;

Fixing by removing the variable.

Link: https://lore.kernel.org/r/20220317030325.30526-1-alexander.vorwerk@stud.uni-goettingen.de
Signed-off-by: Alexander Vorwerk <alexander.vorwerk@stud.uni-goettingen.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptctl.c

index 03c8fb1..f9ee957 100644 (file)
@@ -2334,7 +2334,6 @@ mptctl_hp_hostinfo(MPT_ADAPTER *ioc, unsigned long arg, unsigned int data_size)
        ToolboxIstwiReadWriteRequest_t  *IstwiRWRequest;
        MPT_FRAME_HDR           *mf = NULL;
        unsigned long           timeleft;
-       int                     retval;
        u32                     msgcontext;
 
        /* Reset long to int. Should affect IA64 and SPARC only
@@ -2488,7 +2487,6 @@ mptctl_hp_hostinfo(MPT_ADAPTER *ioc, unsigned long arg, unsigned int data_size)
        ioc->add_sge((char *)&IstwiRWRequest->SGL,
            (MPT_SGE_FLAGS_SSIMPLE_READ|4), buf_dma);
 
-       retval = 0;
        SET_MGMT_MSG_CONTEXT(ioc->ioctl_cmds.msg_context,
                                IstwiRWRequest->MsgContext);
        INITIALIZE_MGMT_STATUS(ioc->ioctl_cmds.status)
@@ -2498,7 +2496,6 @@ retry_wait:
        timeleft = wait_for_completion_timeout(&ioc->ioctl_cmds.done,
                        HZ*MPT_IOCTL_DEFAULT_TIMEOUT);
        if (!(ioc->ioctl_cmds.status & MPT_MGMT_STATUS_COMMAND_GOOD)) {
-               retval = -ETIME;
                printk(MYIOC_s_WARN_FMT "%s: failed\n", ioc->name, __func__);
                if (ioc->ioctl_cmds.status & MPT_MGMT_STATUS_DID_IOCRESET) {
                        mpt_free_msg_frame(ioc, mf);