OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bc30c3b
)
drm/vboxvideo: fix a NULL vs IS_ERR() check
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 18 Nov 2021 11:12:33 +0000
(14:12 +0300)
committer
Hans de Goede
<hdegoede@redhat.com>
Thu, 18 Nov 2021 12:27:14 +0000
(13:27 +0100)
The devm_gen_pool_create() function never returns NULL, it returns
error pointers.
Fixes:
4cc9b565454b
("drm/vboxvideo: Use devm_gen_pool_create")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20211118111233.GA1147@kili
drivers/gpu/drm/vboxvideo/vbox_main.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/vboxvideo/vbox_main.c
b/drivers/gpu/drm/vboxvideo/vbox_main.c
index
f287797
..
c9e8b3a
100644
(file)
--- a/
drivers/gpu/drm/vboxvideo/vbox_main.c
+++ b/
drivers/gpu/drm/vboxvideo/vbox_main.c
@@
-127,8
+127,8
@@
int vbox_hw_init(struct vbox_private *vbox)
/* Create guest-heap mem-pool use 2^4 = 16 byte chunks */
vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1,
"vboxvideo-accel");
- if (
!vbox->guest_pool
)
- return
-ENOMEM
;
+ if (
IS_ERR(vbox->guest_pool)
)
+ return
PTR_ERR(vbox->guest_pool)
;
ret = gen_pool_add_virt(vbox->guest_pool,
(unsigned long)vbox->guest_heap,