OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
df90f83
)
usb: gadget: uvc: remove an impossible condition
author
Dan Carpenter
<dan.carpenter@oracle.com>
Wed, 14 Jan 2015 21:02:18 +0000
(
00:02
+0300)
committer
Felipe Balbi
<balbi@ti.com>
Mon, 19 Jan 2015 18:53:31 +0000
(12:53 -0600)
"num" is a u32 so "(num > 0xFFFFFFFF)" is never true. Also the range
is already checked in kstrtou32().
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/function/uvc_configfs.c
patch
|
blob
|
history
diff --git
a/drivers/usb/gadget/function/uvc_configfs.c
b/drivers/usb/gadget/function/uvc_configfs.c
index
ff30588
..
6d9c681
100644
(file)
--- a/
drivers/usb/gadget/function/uvc_configfs.c
+++ b/
drivers/usb/gadget/function/uvc_configfs.c
@@
-1156,8
+1156,6
@@
static inline int __uvcg_fill_frm_intrv(char *buf, void *priv)
ret = kstrtou32(buf, 0, &num);
if (ret)
return ret;
- if (num > 0xFFFFFFFF)
- return -EINVAL;
interv = priv;
**interv = cpu_to_le32(num);