OSDN Git Service

net/mlx5: Add comment to mlx5_devlink_params_register()
authorJiri Pirko <jiri@nvidia.com>
Tue, 14 Mar 2023 05:42:22 +0000 (22:42 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Mar 2023 05:09:14 +0000 (22:09 -0700)
Add comment to mlx5_devlink_params_register() functions so it is clear
that only driver init params should be registered here.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Link: https://lore.kernel.org/r/20230314054234.267365-4-saeed@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/devlink.c

index c5d2fdc..b7784e0 100644 (file)
@@ -805,6 +805,11 @@ int mlx5_devlink_params_register(struct devlink *devlink)
 {
        int err;
 
+       /* Here only the driver init params should be registered.
+        * Runtime params should be registered by the code which
+        * behaviour they configure.
+        */
+
        err = devl_params_register(devlink, mlx5_devlink_params,
                                   ARRAY_SIZE(mlx5_devlink_params));
        if (err)