OSDN Git Service

drm/i915/selftests: Drop vestigal timeslicing assert
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 7 Apr 2020 22:26:25 +0000 (23:26 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 8 Apr 2020 08:42:17 +0000 (09:42 +0100)
Since the semaphore interrupt may cause us to yield the timeslice
immediately, we may cancel the timer before we notice the submission is
complete. The assertion is no longer valid due to the race with the
interrupt.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200407222625.15542-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/selftest_lrc.c

index 43362b8..57db3d0 100644 (file)
@@ -1073,7 +1073,6 @@ static int live_timeslice_rewind(void *arg)
                               engine->name);
                        goto err;
                }
-               GEM_BUG_ON(!timer_pending(&engine->execlists.timer));
 
                /* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */
                if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */