OSDN Git Service

drm_hwcomposer: fix sign-compare building error in uevent listener
authorMauro Rossi <issor.oruam@gmail.com>
Sun, 16 Jan 2022 15:11:46 +0000 (16:11 +0100)
committerRoman Stratiienko <r.stratiienko@gmail.com>
Tue, 15 Feb 2022 10:06:40 +0000 (12:06 +0200)
d26619b5 ("drm_hwcomposer: CI: Upgrade clang-* to v12") declared 'ret' as ssize_t
but after commit 1e053b4e ("drm_hwcomposer: Make uevent listener standalone")
drm/UEventListener.cpp is affected by the following builing error:

external/drm_hwcomposer/drm/UEventListener.cpp:82:28:
error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'ssize_t' (aka 'int') [-Werror,-Wsign-compare]
    for (uint32_t i = 0; i < ret;) {
                         ~ ^ ~~~
1 error generated.

Fixes: 1e053b4e ("drm_hwcomposer: Make uevent listener standalone")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
[RomanS: Fixed CI nitpicks]
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Change-Id: Ia97d9019c21ac68be386a627cb101f6e423bbfc7

drm/UEventListener.cpp

index 44c503d..8d33ad2 100644 (file)
@@ -79,7 +79,7 @@ void UEventListener::Routine() {
 
     bool drm_event = false;
     bool hotplug_event = false;
-    for (uint32_t i = 0; i < ret;) {
+    for (uint32_t i = 0; (ssize_t)i < ret;) {
       char *event = buffer + i;
       if (strcmp(event, "DEVTYPE=drm_minor") != 0)
         drm_event = true;