OSDN Git Service

leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity()
authorJacek Anaszewski <j.anaszewski@samsung.com>
Mon, 18 Apr 2016 14:09:55 +0000 (16:09 +0200)
committerJacek Anaszewski <j.anaszewski@samsung.com>
Tue, 19 Apr 2016 06:57:16 +0000 (08:57 +0200)
Parameters delay_on and delay_off of led_trigger_blink_oneshot()
are pointers, to enable blink interval adjustment by LED class drivers
of the controllers that implement hardware blinking.

Move ide_blink_delay variable to ledtrig_ide_activity() in order to
prevent the situation when adjustment committed by one LED class
driver influences blink interval of the software fallback blink feature,
that is applied to the drivers that don't implement blink_set op.

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
drivers/leds/trigger/ledtrig-ide-disk.c

index c02a3ac..15123d3 100644 (file)
 #define BLINK_DELAY 30
 
 DEFINE_LED_TRIGGER(ledtrig_ide);
-static unsigned long ide_blink_delay = BLINK_DELAY;
 
 void ledtrig_ide_activity(void)
 {
+       unsigned long ide_blink_delay = BLINK_DELAY;
+
        led_trigger_blink_oneshot(ledtrig_ide,
                                  &ide_blink_delay, &ide_blink_delay, 0);
 }