OSDN Git Service

pty: Fix byte loss bug when connecting to pty
authorSebastian Tanase <sebastian.tanase@openwide.fr>
Mon, 28 Jul 2014 11:39:14 +0000 (13:39 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 5 Sep 2014 11:27:10 +0000 (13:27 +0200)
When trying to print data to the pty, we first check if it is connected.
If not, we try to reconnect, but we drop the pending data even if we
have successfully reconnected; this makes us lose the first byte of the very
first transmission.
This small fix addresses the issue by checking once more if the pty is connected
after having tried to reconnect.

Signed-off-by: Sebastian Tanase <sebastian.tanase@openwide.fr>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
qemu-char.c

index d4f327a..1a8d9aa 100644 (file)
@@ -1160,7 +1160,9 @@ static int pty_chr_write(CharDriverState *chr, const uint8_t *buf, int len)
     if (!s->connected) {
         /* guest sends data, check for (re-)connect */
         pty_chr_update_read_handler_locked(chr);
-        return 0;
+        if (!s->connected) {
+            return 0;
+        }
     }
     return io_channel_send(s->fd, buf, len);
 }