OSDN Git Service

drm/client: remove the exporting of drm_client_close
authorDenis Efremov <efremov@linux.com>
Wed, 3 Jul 2019 17:01:50 +0000 (20:01 +0300)
committerNoralf Trønnes <noralf@tronnes.org>
Tue, 9 Jul 2019 09:34:39 +0000 (11:34 +0200)
The function drm_client_close is declared as static and marked as
EXPORT_SYMBOL. It's a bit confusing for an internal function to be
exported. The area of visibility for such function is its .c file
and all other modules. Other *.c files of the same module can't use it,
despite all other modules can. Relying on the fact that this is the
internal function and it's not a crucial part of the API, the patch
removes the EXPORT_SYMBOL marking of drm_client_close.

Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190703170150.32548-1-efremov@linux.com
drivers/gpu/drm/drm_client.c

index e1dafb0..d9a2e36 100644 (file)
@@ -59,7 +59,6 @@ static void drm_client_close(struct drm_client_dev *client)
 
        drm_file_free(client->file);
 }
-EXPORT_SYMBOL(drm_client_close);
 
 /**
  * drm_client_init - Initialise a DRM client