OSDN Git Service

net: dsa: lantiq: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 15 Sep 2022 11:42:11 +0000 (19:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Sep 2022 12:50:03 +0000 (13:50 +0100)
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lantiq_gswip.c

index e531b93..88f95d6 100644 (file)
@@ -1989,11 +1989,9 @@ static int gswip_gphy_fw_probe(struct gswip_priv *priv,
        }
 
        gphy_fw->reset = of_reset_control_array_get_exclusive(gphy_fw_np);
-       if (IS_ERR(gphy_fw->reset)) {
-               if (PTR_ERR(gphy_fw->reset) != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to lookup gphy reset\n");
-               return PTR_ERR(gphy_fw->reset);
-       }
+       if (IS_ERR(gphy_fw->reset))
+               return dev_err_probe(dev, PTR_ERR(gphy_fw->reset),
+                                    "Failed to lookup gphy reset\n");
 
        return gswip_gphy_fw_load(priv, gphy_fw);
 }