OSDN Git Service

hwrng: tx4939 - use devm_request_and_ioremap
authorJulia Lawall <julia@diku.dk>
Tue, 27 Dec 2011 14:01:30 +0000 (15:01 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 13 Jan 2012 05:38:40 +0000 (16:38 +1100)
Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@nm@
expression myname;
identifier i;
@@

struct platform_driver i = { .driver = { .name = myname } };

@@
expression dev,res,size;
expression nm.myname;
@@

-if (!devm_request_mem_region(dev, res->start, size,
-                              \(res->name\|dev_name(dev)\|myname\))) {
-   ...
-   return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
    when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/tx4939-rng.c

index 0bc0cb7..de473ef 100644 (file)
@@ -115,10 +115,7 @@ static int __init tx4939_rng_probe(struct platform_device *dev)
        rngdev = devm_kzalloc(&dev->dev, sizeof(*rngdev), GFP_KERNEL);
        if (!rngdev)
                return -ENOMEM;
-       if (!devm_request_mem_region(&dev->dev, r->start, resource_size(r),
-                                    dev_name(&dev->dev)))
-               return -EBUSY;
-       rngdev->base = devm_ioremap(&dev->dev, r->start, resource_size(r));
+       rngdev->base = devm_request_and_ioremap(&dev->dev, r);
        if (!rngdev->base)
                return -EBUSY;