OSDN Git Service

Merge "Adding guardrails on writing to disk from statsd"
authorTreeHugger Robot <treehugger-gerrit@google.com>
Thu, 25 Jan 2018 06:47:29 +0000 (06:47 +0000)
committerAndroid (Google) Code Review <android-gerrit@google.com>
Thu, 25 Jan 2018 06:47:29 +0000 (06:47 +0000)
1  2 
cmds/statsd/Android.mk
cmds/statsd/src/StatsLogProcessor.cpp
cmds/statsd/src/config/ConfigManager.cpp
cmds/statsd/src/storage/StorageManager.cpp
cmds/statsd/src/storage/StorageManager.h

Simple merge
@@@ -325,10 -305,10 +325,10 @@@ void StatsLogProcessor::WriteDataToDisk
      for (auto& pair : mMetricsManagers) {
          const ConfigKey& key = pair.first;
          vector<uint8_t> data;
 -        onDumpReport(key, &data);
 +        onDumpReportLocked(key, &data);
          // TODO: Add a guardrail to prevent accumulation of file on disk.
-         string file_name = StringPrintf("%s/%d-%lld-%ld", STATS_DATA_DIR, key.GetUid(),
-                                         (long long)key.GetId(), time(nullptr));
+         string file_name = StringPrintf("%s/%ld_%d_%lld", STATS_DATA_DIR, time(nullptr),
+                                         key.GetUid(), (long long)key.GetId());
          StorageManager::writeFile(file_name.c_str(), &data[0], data.size());
      }
  }