OSDN Git Service

gpio: Add missing spin_lock_init in gpio-pch driver
authorAxel Lin <axel.lin@gmail.com>
Wed, 1 Feb 2012 02:51:53 +0000 (10:51 +0800)
committerGrant Likely <grant.likely@secretlab.ca>
Thu, 2 Feb 2012 04:59:15 +0000 (21:59 -0700)
This bug was introduced by commit d568a681
"gpio-pch: add spinlock in suspend/resume processing"
which adds a spinlock to struct pch_gpio but never init the spinlock.

Reported-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/gpio/gpio-pch.c

index 68fa55e..e8729cc 100644 (file)
@@ -392,6 +392,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev,
        chip->reg = chip->base;
        pci_set_drvdata(pdev, chip);
        mutex_init(&chip->lock);
+       spin_lock_init(&chip->spinlock);
        pch_gpio_setup(chip);
        ret = gpiochip_add(&chip->gpio);
        if (ret) {