OSDN Git Service

net: sgi: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
authorYang Wei <yang.wei9@zte.com.cn>
Wed, 13 Feb 2019 15:17:06 +0000 (23:17 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2019 16:56:36 +0000 (11:56 -0500)
dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sgi/ioc3-eth.c
drivers/net/ethernet/sgi/meth.c

index 3140999..358e66b 100644 (file)
@@ -666,7 +666,7 @@ static inline void ioc3_tx(struct net_device *dev)
                packets++;
                skb = ip->tx_skbs[o_entry];
                bytes += skb->len;
-               dev_kfree_skb_irq(skb);
+               dev_consume_skb_irq(skb);
                ip->tx_skbs[o_entry] = NULL;
 
                o_entry = (o_entry + 1) & 127;          /* Next */
index 67954a9..f425ab5 100644 (file)
@@ -525,7 +525,7 @@ static void meth_tx_cleanup(struct net_device* dev, unsigned long int_status)
                        DPRINTK("RPTR points us here, but packet not done?\n");
                        break;
                }
-               dev_kfree_skb_irq(skb);
+               dev_consume_skb_irq(skb);
                priv->tx_skbs[priv->tx_read] = NULL;
                priv->tx_ring[priv->tx_read].header.raw = 0;
                priv->tx_read = (priv->tx_read+1)&(TX_RING_ENTRIES-1);