OSDN Git Service

spi: omap-100k: Fix memory leak
authorAxel Lin <axel.lin@ingics.com>
Sat, 29 Mar 2014 07:03:37 +0000 (15:03 +0800)
committerMark Brown <broonie@linaro.org>
Sat, 29 Mar 2014 10:01:13 +0000 (10:01 +0000)
The memory allocated for cs is not freed anywhere.
Convert to use devm_kzalloc to fix the memory leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-omap-100k.c

index c9e2282..e7ffcde 100644 (file)
@@ -283,7 +283,7 @@ static int omap1_spi100k_setup(struct spi_device *spi)
        spi100k = spi_master_get_devdata(spi->master);
 
        if (!cs) {
-               cs = kzalloc(sizeof(*cs), GFP_KERNEL);
+               cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL);
                if (!cs)
                        return -ENOMEM;
                cs->base = spi100k->base + spi->chip_select * 0x14;