OSDN Git Service

mmc: queue: Remove BUG_ON() in cmdq_thread
authorVijay Viswanath <vviswana@codeaurora.org>
Fri, 17 Mar 2017 13:26:18 +0000 (18:56 +0530)
committerGerrit - the friendly Code Review server <code-review@localhost>
Mon, 1 May 2017 09:05:40 +0000 (02:05 -0700)
If any discard requests fails, the mmc driver should not cause kernel
panic. The error handling and informing block layer about error will be
done by completion context.

Change-Id: I0c88ad851ad12c392a557bcb94d3b21dfc62d1f8
Signed-off-by: Vijay Viswanath <vviswana@codeaurora.org>
drivers/mmc/card/queue.c

index f5dbb67..ccf22eb 100644 (file)
@@ -128,14 +128,11 @@ static int mmc_cmdq_thread(void *d)
 
                ret = mq->cmdq_issue_fn(mq, mq->cmdq_req_peeked);
                /*
-                * Don't requeue if issue_fn fails, just bug on.
-                * We don't expect failure here and there is no recovery other
-                * than fixing the actual issue if there is any.
+                * Don't requeue if issue_fn fails.
+                * Recovery will be come by completion softirq
                 * Also we end the request if there is a partition switch error,
                 * so we should not requeue the request here.
                 */
-               if (ret)
-                       BUG_ON(1);
        } /* loop */
 
        return 0;