OSDN Git Service

RDMA/isert: Suppress gcc 7 fall-through complaints
authorBart Van Assche <bart.vanassche@wdc.com>
Wed, 11 Oct 2017 17:48:47 +0000 (10:48 -0700)
committerDoug Ledford <dledford@redhat.com>
Sun, 15 Oct 2017 00:47:05 +0000 (20:47 -0400)
Avoid that gcc 7 reports the following warning when building with W=1:

warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Acked-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/ulp/isert/ib_isert.c

index ceabdb8..720dfb3 100644 (file)
@@ -788,10 +788,11 @@ isert_cma_handler(struct rdma_cm_id *cma_id, struct rdma_cm_event *event)
                 * the rdma cm id
                 */
                return 1;
-       case RDMA_CM_EVENT_REJECTED:       /* FALLTHRU */
+       case RDMA_CM_EVENT_REJECTED:
                isert_info("Connection rejected: %s\n",
                           rdma_reject_msg(cma_id, event->status));
-       case RDMA_CM_EVENT_UNREACHABLE:    /* FALLTHRU */
+               /* fall through */
+       case RDMA_CM_EVENT_UNREACHABLE:
        case RDMA_CM_EVENT_CONNECT_ERROR:
                ret = isert_connect_error(cma_id);
                break;
@@ -1569,9 +1570,7 @@ isert_put_cmd(struct isert_cmd *isert_cmd, bool comp_err)
                        transport_generic_free_cmd(&cmd->se_cmd, 0);
                        break;
                }
-               /*
-                * Fall-through
-                */
+               /* fall through */
        default:
                iscsit_release_cmd(cmd);
                break;
@@ -1749,8 +1748,9 @@ isert_do_control_comp(struct work_struct *work)
        switch (cmd->i_state) {
        case ISTATE_SEND_TASKMGTRSP:
                iscsit_tmr_post_handler(cmd, cmd->conn);
-       case ISTATE_SEND_REJECT:   /* FALLTHRU */
-       case ISTATE_SEND_TEXTRSP:  /* FALLTHRU */
+               /* fall through */
+       case ISTATE_SEND_REJECT:
+       case ISTATE_SEND_TEXTRSP:
                cmd->i_state = ISTATE_SENT_STATUS;
                isert_completion_put(&isert_cmd->tx_desc, isert_cmd,
                                     ib_dev, false);