OSDN Git Service

iwlwifi: check RF kill register when interrupts have been disabled
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Wed, 28 Mar 2012 08:34:02 +0000 (10:34 +0200)
committerWey-Yi Guy <wey-yi.w.guy@intel.com>
Mon, 23 Apr 2012 21:19:31 +0000 (14:19 -0700)
Since the interrupts have been disabled, we may have missed an RF
kill interrupt. Check the register to be sure the op_mode is in
sync.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
drivers/net/wireless/iwlwifi/iwl-trans-pcie.c

index 589037d..8e1cf97 100644 (file)
@@ -1438,12 +1438,22 @@ error:
 
 static void iwl_trans_pcie_stop_hw(struct iwl_trans *trans)
 {
+       bool hw_rfkill;
+
        iwl_apm_stop(trans);
 
        iwl_write32(trans, CSR_INT, 0xFFFFFFFF);
 
        /* Even if we stop the HW, we still want the RF kill interrupt */
        iwl_enable_rfkill_int(trans);
+
+       /*
+        * Check again since the RF kill state may have changed while all the
+        * interrupts were disabled, in this case we couldn't receive the
+        * RF kill interrupt and update the state in the op_mode.
+        */
+       hw_rfkill = iwl_is_rfkill_set(trans);
+       iwl_op_mode_hw_rf_kill(trans->op_mode, hw_rfkill);
 }
 
 static void iwl_trans_pcie_reclaim(struct iwl_trans *trans, int txq_id, int ssn,