OSDN Git Service

staging: rtl8192e: remove redundant variable shadowing
authorNikolay Kyx <knv418@gmail.com>
Tue, 2 Mar 2021 13:32:17 +0000 (16:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:25:33 +0000 (09:25 +0100)
In function rtl92e_start_adapter() automatic variable 'i' referenced only
within certain loops, used as iteration counter. Control flow can't get
into such loop w/o 'i = 0' assignment.

It's redundant to shadow this variable by creating scope around loop.

This patch fixes the following sparse warning:

warning: symbol 'i' shadows an earlier one

Signed-off-by: Nikolay Kyx <knv418@gmail.com>
Link: https://lore.kernel.org/r/20210302133217.145994-1-knv418@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c

index ff843d7..8cd085e 100644 (file)
@@ -800,12 +800,10 @@ start:
        }
        rtl92e_writew(dev, ATIMWND, 2);
        rtl92e_writew(dev, BCN_INTERVAL, 100);
-       {
-               int i;
 
-               for (i = 0; i < QOS_QUEUE_NUM; i++)
-                       rtl92e_writel(dev, WDCAPARA_ADD[i], 0x005e4332);
-       }
+       for (i = 0; i < QOS_QUEUE_NUM; i++)
+               rtl92e_writel(dev, WDCAPARA_ADD[i], 0x005e4332);
+
        rtl92e_writeb(dev, 0xbe, 0xc0);
 
        rtl92e_config_mac(dev);