OSDN Git Service

net: calxedaxgmac: remove some unused statistic counters
authorRob Herring <rob.herring@calxeda.com>
Fri, 30 Aug 2013 21:49:27 +0000 (16:49 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Sep 2013 02:21:16 +0000 (22:21 -0400)
rx_sa_filter_fail and tx_undeflow events are unused and impossible
to occur based on how the h/w is used. We never filter on source MAC
address and TX store and forward mode prevents underflow events.

Reported-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/calxeda/xgmac.c

index 0cff9e3..04c585c 100644 (file)
@@ -353,11 +353,9 @@ struct xgmac_extra_stats {
        /* Receive errors */
        unsigned long rx_watchdog;
        unsigned long rx_da_filter_fail;
-       unsigned long rx_sa_filter_fail;
        unsigned long rx_payload_error;
        unsigned long rx_ip_header_error;
        /* Tx/Rx IRQ errors */
-       unsigned long tx_undeflow;
        unsigned long tx_process_stopped;
        unsigned long rx_buf_unav;
        unsigned long rx_process_stopped;
@@ -1581,7 +1579,6 @@ static const struct xgmac_stats xgmac_gstrings_stats[] = {
        XGMAC_STAT(rx_payload_error),
        XGMAC_STAT(rx_ip_header_error),
        XGMAC_STAT(rx_da_filter_fail),
-       XGMAC_STAT(rx_sa_filter_fail),
        XGMAC_STAT(fatal_bus_error),
        XGMAC_HW_STAT(rx_watchdog, XGMAC_MMC_RXWATCHDOG),
        XGMAC_HW_STAT(tx_vlan, XGMAC_MMC_TXVLANFRAME),