OSDN Git Service
(root)
/
sagit-ice-cold
/
kernel_xiaomi_msm8998.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
87250dd
)
locks: convert an -EINVAL return to a BUG
author
J. Bruce Fields
<bfields@citi.umich.edu>
Sat, 30 Jun 2007 16:40:32 +0000
(12:40 -0400)
committer
J. Bruce Fields
<bfields@citi.umich.edu>
Wed, 18 Jul 2007 23:09:27 +0000
(19:09 -0400)
There's no point trying to return an error in these cases, which all represent
bugs in the callers.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/locks.c
patch
|
blob
|
history
diff --git
a/fs/locks.c
b/fs/locks.c
index
924e4a7
..
3c23fd2
100644
(file)
--- a/
fs/locks.c
+++ b/
fs/locks.c
@@
-1348,9
+1348,7
@@
static int __setlease(struct file *filp, long arg, struct file_lock **flp)
time_out_leases(inode);
- error = -EINVAL;
- if (!flp || !(*flp) || !(*flp)->fl_lmops || !(*flp)->fl_lmops->fl_break)
- goto out;
+ BUG_ON(!(*flp)->fl_lmops->fl_break);
lease = *flp;