usb: dwc3: omap: add dwc3_omap_set_utmi_mode() function

Move find and set the utmi mode to its own separate function.
Improve code readability, decrease the dwc3_probe() size.

Signed-off-by: George Cherian <george.cherian@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 22fca62..6a90b96 100644 (file)
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -399,6 +399,30 @@ static void dwc3_omap_map_offset(struct dwc3_omap *omap)
        }
 }
 
+static void dwc3_omap_set_utmi_mode(struct dwc3_omap *omap)
+{
+       u32                     reg;
+       struct device_node      *node = omap->dev->of_node;
+       int                     utmi_mode = 0;
+
+       reg = dwc3_omap_read_utmi_status(omap);
+
+       of_property_read_u32(node, "utmi-mode", &utmi_mode);
+
+       switch (utmi_mode) {
+       case DWC3_OMAP_UTMI_MODE_SW:
+               reg |= USBOTGSS_UTMI_OTG_STATUS_SW_MODE;
+               break;
+       case DWC3_OMAP_UTMI_MODE_HW:
+               reg &= ~USBOTGSS_UTMI_OTG_STATUS_SW_MODE;
+               break;
+       default:
+               dev_dbg(omap->dev, "UNKNOWN utmi mode %d\n", utmi_mode);
+       }
+
+       dwc3_omap_write_utmi_status(omap, reg);
+}
+
 static int dwc3_omap_probe(struct platform_device *pdev)
 {
        struct device_node      *node = pdev->dev.of_node;
@@ -412,8 +436,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        int                     ret;
        int                     irq;
 
-       int                     utmi_mode = 0;
-
        u32                     reg;
 
        void __iomem            *base;
@@ -464,23 +486,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        }
 
        dwc3_omap_map_offset(omap);
-
-       reg = dwc3_omap_read_utmi_status(omap);
-
-       of_property_read_u32(node, "utmi-mode", &utmi_mode);
-
-       switch (utmi_mode) {
-       case DWC3_OMAP_UTMI_MODE_SW:
-               reg |= USBOTGSS_UTMI_OTG_STATUS_SW_MODE;
-               break;
-       case DWC3_OMAP_UTMI_MODE_HW:
-               reg &= ~USBOTGSS_UTMI_OTG_STATUS_SW_MODE;
-               break;
-       default:
-               dev_dbg(dev, "UNKNOWN utmi mode %d\n", utmi_mode);
-       }
-
-       dwc3_omap_write_utmi_status(omap, reg);
+       dwc3_omap_set_utmi_mode(omap);
 
        /* check the DMA Status */
        reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);