OSDN Git Service

perf tools: Remove addr_location argument to sample__fprintf_callchain
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 14 Apr 2016 20:53:49 +0000 (17:53 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 14 Apr 2016 22:46:57 +0000 (19:46 -0300)
Not used at all, nuke it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-jf2w8ce8nl3wso3vuodg5jci@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c
tools/perf/util/evsel.c
tools/perf/util/evsel.h

index 0e2a82b..5e5a95e 100644 (file)
@@ -1898,8 +1898,7 @@ static int trace__fprintf_callchain(struct trace *trace, struct perf_evsel *evse
                return 0;
        }
 
-       return sample__fprintf_callchain(sample, &al, 38, print_opts,
-                                        &callchain_cursor, trace->output);
+       return sample__fprintf_callchain(sample, 38, print_opts, &callchain_cursor, trace->output);
 }
 
 static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,
index 35c5a52..060f619 100644 (file)
@@ -2343,8 +2343,7 @@ out:
        return ++printed;
 }
 
-int sample__fprintf_callchain(struct perf_sample *sample,
-                             struct addr_location *al, int left_alignment,
+int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
                              unsigned int print_opts, struct callchain_cursor *cursor,
                              FILE *fp)
 {
@@ -2364,9 +2363,6 @@ int sample__fprintf_callchain(struct perf_sample *sample,
 
                callchain_cursor_commit(cursor);
 
-               if (print_symoffset)
-                       node_al = *al;
-
                while (1) {
                        u64 addr = 0;
 
@@ -2431,7 +2427,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,
        int print_unknown_as_addr = print_opts & EVSEL__PRINT_UNKNOWN_AS_ADDR;
 
        if (cursor != NULL) {
-               printed += sample__fprintf_callchain(sample, al, left_alignment,
+               printed += sample__fprintf_callchain(sample, left_alignment,
                                                     print_opts, cursor, fp);
        } else if (!(al->sym && al->sym->ignore)) {
                printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
index abadfea..b993218 100644 (file)
@@ -397,8 +397,8 @@ int perf_evsel__fprintf(struct perf_evsel *evsel,
 
 struct callchain_cursor;
 
-int sample__fprintf_callchain(struct perf_sample *sample, struct addr_location *al,
-                             int left_alignment, unsigned int print_opts,
+int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
+                             unsigned int print_opts,
                              struct callchain_cursor *cursor, FILE *fp);
 
 int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,