OSDN Git Service

qed: Fix a error code in qed_hw_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 31 Jan 2020 05:03:26 +0000 (08:03 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 1 Feb 2020 19:35:17 +0000 (11:35 -0800)
If the qed_fw_overlay_mem_alloc() then we should return -ENOMEM instead
of success.

Fixes: 30d5f85895fa ("qed: FW 8.42.2.0 Add fw overlay feature")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_dev.c

index 7912911..03bdd2e 100644 (file)
@@ -3114,6 +3114,7 @@ int qed_hw_init(struct qed_dev *cdev, struct qed_hw_init_params *p_params)
                if (!p_hwfn->fw_overlay_mem) {
                        DP_NOTICE(p_hwfn,
                                  "Failed to allocate fw overlay memory\n");
+                       rc = -ENOMEM;
                        goto load_err;
                }