OSDN Git Service

tty: hvsi: remove an extra variable from hvsi_write()
authorJiri Slaby <jirislaby@kernel.org>
Mon, 31 Jul 2023 08:02:37 +0000 (10:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Jul 2023 15:16:05 +0000 (17:16 +0200)
'source' is the same as 'buf'. Rename the parameter ('buf') to
'source' and drop the local variable.

Likely, the two were introduced to have a different type. But 'char' and
'unsigned char' are the same in the kernel for a long time.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Link: https://lore.kernel.org/r/20230731080244.2698-4-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/hvc/hvsi.c

index a200d01..c1b8a4f 100644 (file)
@@ -905,10 +905,9 @@ static unsigned int hvsi_chars_in_buffer(struct tty_struct *tty)
 }
 
 static int hvsi_write(struct tty_struct *tty,
-                    const unsigned char *buf, int count)
+                    const unsigned char *source, int count)
 {
        struct hvsi_struct *hp = tty->driver_data;
-       const char *source = buf;
        unsigned long flags;
        int total = 0;
        int origcount = count;