OSDN Git Service
(root)
/
android-x86
/
kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
064bff1
)
smsc95xx: signedness bug in get_regs()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 10 Jul 2012 20:32:51 +0000
(20:32 +0000)
committer
David S. Miller
<davem@davemloft.net>
Thu, 12 Jul 2012 14:54:45 +0000
(07:54 -0700)
"retval" has to be a signed integer for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/smsc95xx.c
patch
|
blob
|
history
diff --git
a/drivers/net/usb/smsc95xx.c
b/drivers/net/usb/smsc95xx.c
index
05ecf14
..
bd7cbaa
100644
(file)
--- a/
drivers/net/usb/smsc95xx.c
+++ b/
drivers/net/usb/smsc95xx.c
@@
-589,7
+589,8
@@
smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
void *buf)
{
struct usbnet *dev = netdev_priv(netdev);
- unsigned int i, j, retval;
+ unsigned int i, j;
+ int retval;
u32 *data = buf;
retval = smsc95xx_read_reg(dev, ID_REV, ®s->version);