OSDN Git Service

ASoC: soc-core: fix signed/unsigned issue
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 16 Apr 2021 19:11:41 +0000 (14:11 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 19 Apr 2021 13:03:30 +0000 (14:03 +0100)
cppcheck warning:

sound/soc/soc-core.c:2237:13: warning: %x in format string (no. 1)
requires 'unsigned int *' but the argument type is 'signed
int *'. [invalidScanfArgType_int]
 } else if (sscanf(name, "%x-%x", &id1, &id2) == 2) {
            ^
sound/soc/soc-core.c:2237:13: warning: %x in format string (no. 2)
requires 'unsigned int *' but the argument type is 'signed
int *'. [invalidScanfArgType_int]
 } else if (sscanf(name, "%x-%x", &id1, &id2) == 2) {
            ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20210416191144.27006-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c

index 80374c8..fb6b3a6 100644 (file)
@@ -2219,7 +2219,7 @@ static char *fmt_single_name(struct device *dev, int *id)
 {
        const char *devname = dev_name(dev);
        char *found, *name;
-       int id1, id2;
+       unsigned int id1, id2;
 
        if (devname == NULL)
                return NULL;