OSDN Git Service

cifs: don't override the uid/gid in getattr when cifsacl is enabled
authorJeff Layton <jlayton@redhat.com>
Sun, 25 Nov 2012 13:00:40 +0000 (08:00 -0500)
committerSteve French <smfrench@gmail.com>
Wed, 5 Dec 2012 19:13:12 +0000 (13:13 -0600)
If we're using cifsacl, then we don't want to override the uid/gid with
the current uid/gid, since that would prevent you from being able to
upcall for this info.

Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/inode.c

index afdff79..ed6208f 100644 (file)
@@ -1791,11 +1791,12 @@ int cifs_getattr(struct vfsmount *mnt, struct dentry *dentry,
        stat->ino = CIFS_I(inode)->uniqueid;
 
        /*
-        * If on a multiuser mount without unix extensions, and the admin hasn't
-        * overridden them, set the ownership to the fsuid/fsgid of the current
-        * process.
+        * If on a multiuser mount without unix extensions or cifsacl being
+        * enabled, and the admin hasn't overridden them, set the ownership
+        * to the fsuid/fsgid of the current process.
         */
        if ((cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MULTIUSER) &&
+           !(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) &&
            !tcon->unix_ext) {
                if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_UID))
                        stat->uid = current_fsuid();