OSDN Git Service

gpio-tz1090: Replace commas with semi-colons
authorJames Hogan <james.hogan@imgtec.com>
Tue, 4 Mar 2014 11:28:48 +0000 (11:28 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 7 Mar 2014 03:57:00 +0000 (11:57 +0800)
Replace commas with semicolons between irqchip callback initialisation
statements in tz1090_gpio_bank_probe. The commas appear to be a subtle
remnant of when the irqchips were statically initialised.

Thanks to Thomas Gleixner for spotting it while whipping up a coccinelle
script.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-metag@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-tz1090.c

index 23e0613..5246a60 100644 (file)
@@ -488,26 +488,26 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
        gc->chip_types[0].handler               = handle_level_irq;
        gc->chip_types[0].regs.ack              = REG_GPIO_IRQ_STS;
        gc->chip_types[0].regs.mask             = REG_GPIO_IRQ_EN;
-       gc->chip_types[0].chip.irq_startup      = gpio_startup_irq,
-       gc->chip_types[0].chip.irq_ack          = irq_gc_ack_clr_bit,
-       gc->chip_types[0].chip.irq_mask         = irq_gc_mask_clr_bit,
-       gc->chip_types[0].chip.irq_unmask       = irq_gc_mask_set_bit,
-       gc->chip_types[0].chip.irq_set_type     = gpio_set_irq_type,
-       gc->chip_types[0].chip.irq_set_wake     = gpio_set_irq_wake,
-       gc->chip_types[0].chip.flags            = IRQCHIP_MASK_ON_SUSPEND,
+       gc->chip_types[0].chip.irq_startup      = gpio_startup_irq;
+       gc->chip_types[0].chip.irq_ack          = irq_gc_ack_clr_bit;
+       gc->chip_types[0].chip.irq_mask         = irq_gc_mask_clr_bit;
+       gc->chip_types[0].chip.irq_unmask       = irq_gc_mask_set_bit;
+       gc->chip_types[0].chip.irq_set_type     = gpio_set_irq_type;
+       gc->chip_types[0].chip.irq_set_wake     = gpio_set_irq_wake;
+       gc->chip_types[0].chip.flags            = IRQCHIP_MASK_ON_SUSPEND;
 
        /* edge chip type */
        gc->chip_types[1].type                  = IRQ_TYPE_EDGE_BOTH;
        gc->chip_types[1].handler               = handle_edge_irq;
        gc->chip_types[1].regs.ack              = REG_GPIO_IRQ_STS;
        gc->chip_types[1].regs.mask             = REG_GPIO_IRQ_EN;
-       gc->chip_types[1].chip.irq_startup      = gpio_startup_irq,
-       gc->chip_types[1].chip.irq_ack          = irq_gc_ack_clr_bit,
-       gc->chip_types[1].chip.irq_mask         = irq_gc_mask_clr_bit,
-       gc->chip_types[1].chip.irq_unmask       = irq_gc_mask_set_bit,
-       gc->chip_types[1].chip.irq_set_type     = gpio_set_irq_type,
-       gc->chip_types[1].chip.irq_set_wake     = gpio_set_irq_wake,
-       gc->chip_types[1].chip.flags            = IRQCHIP_MASK_ON_SUSPEND,
+       gc->chip_types[1].chip.irq_startup      = gpio_startup_irq;
+       gc->chip_types[1].chip.irq_ack          = irq_gc_ack_clr_bit;
+       gc->chip_types[1].chip.irq_mask         = irq_gc_mask_clr_bit;
+       gc->chip_types[1].chip.irq_unmask       = irq_gc_mask_set_bit;
+       gc->chip_types[1].chip.irq_set_type     = gpio_set_irq_type;
+       gc->chip_types[1].chip.irq_set_wake     = gpio_set_irq_wake;
+       gc->chip_types[1].chip.flags            = IRQCHIP_MASK_ON_SUSPEND;
 
        /* Setup chained handler for this GPIO bank */
        irq_set_handler_data(bank->irq, bank);