OSDN Git Service

[lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex
authorPavel Labath <pavel@labath.sk>
Fri, 24 Jan 2020 11:07:00 +0000 (12:07 +0100)
committerPavel Labath <pavel@labath.sk>
Fri, 24 Jan 2020 11:09:20 +0000 (12:09 +0100)
This was needed when asking a compile unit for its dwo component
triggered a infinite recursion if the dwo unit has not been already
parsed.

This has since been fixed.

lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

index 3cd082b..705578c 100644 (file)
@@ -53,12 +53,7 @@ DebugNamesDWARFIndex::ToDIERef(const DebugNames::Entry &entry) {
   if (!cu)
     return llvm::None;
 
-  // This initializes the DWO symbol file. It's not possible for
-  // GetDwoSymbolFile to call this automatically because of mutual recursion
-  // between this and DWARFDebugInfoEntry::GetAttributeValue.
-  cu->ExtractUnitDIEIfNeeded();
   cu = &cu->GetNonSkeletonUnit();
-
   if (llvm::Optional<uint64_t> die_offset = entry.getDIEUnitOffset())
     return DIERef(cu->GetSymbolFileDWARF().GetDwoNum(),
                   DIERef::Section::DebugInfo, cu->GetOffset() + *die_offset);