OSDN Git Service

[media] staging: omap4iss: copy paste error in iss_get_clocks
authorVitaly Osipov <vitaly.osipov@gmail.com>
Thu, 5 Jun 2014 07:07:48 +0000 (04:07 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Thu, 21 Aug 2014 20:25:34 +0000 (15:25 -0500)
It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The
current code looks like an oversight in pasting the block just above
this one.

Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/staging/media/omap4iss/iss.c

index d548371..8a23d16 100644 (file)
@@ -1014,6 +1014,7 @@ static int iss_get_clocks(struct iss_device *iss)
        iss->iss_ctrlclk = devm_clk_get(iss->dev, "iss_ctrlclk");
        if (IS_ERR(iss->iss_ctrlclk)) {
                dev_err(iss->dev, "Unable to get iss_ctrlclk clock info\n");
+               iss_put_clocks(iss);
                return PTR_ERR(iss->iss_ctrlclk);
        }