}
break;
- case Intrinsic::uadd_with_overflow: // FALLTHROUGH
- case Intrinsic::sadd_with_overflow: // FALLTHROUGH
- case Intrinsic::usub_with_overflow: // FALLTHROUGH
- case Intrinsic::ssub_with_overflow: // FALLTHROUGH
- case Intrinsic::umul_with_overflow: // FALLTHROUGH
- case Intrinsic::smul_with_overflow: {
+ case Intrinsic::uadd_with_overflow:
+ case Intrinsic::sadd_with_overflow:
+ case Intrinsic::umul_with_overflow:
+ case Intrinsic::smul_with_overflow:
if (isa<Constant>(II->getArgOperand(0)) &&
!isa<Constant>(II->getArgOperand(1))) {
// Canonicalize constants into the RHS.
II->setArgOperand(1, LHS);
return II;
}
+ [[clang::fallthrough]];
+ case Intrinsic::usub_with_overflow:
+ case Intrinsic::ssub_with_overflow: {
OverflowCheckFlavor OCF =
IntrinsicIDToOverflowCheckFlavor(II->getIntrinsicID());
assert(OCF != OCF_INVALID && "unexpected!");
bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
Value *RHS, Instruction &OrigI,
Value *&Result, Constant *&Overflow) {
- assert(!(isa<Constant>(LHS) && !isa<Constant>(RHS)) &&
+ assert((!OrigI.isCommutative() ||
+ !(isa<Constant>(LHS) && !isa<Constant>(RHS))) &&
"call with a constant RHS if possible!");
auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
%obit = extractvalue %ov.result.32 %t, 1
ret i1 %obit
}
+
+define %ov.result.32 @ssubtest_reorder(i8 %a) {
+ %A = sext i8 %a to i32
+ %x = call %ov.result.32 @llvm.ssub.with.overflow.i32(i32 0, i32 %A)
+ ret %ov.result.32 %x
+; CHECK-LABEL: @ssubtest_reorder
+; CHECK: %x = sub nsw i32 0, %A
+; CHECK-NEXT: %1 = insertvalue %ov.result.32 { i32 undef, i1 false }, i32 %x, 0
+; CHECK-NEXT: ret %ov.result.32 %1
+}