OSDN Git Service

crypto: testmgr - remove unused function argument
authorCristian Stoica <cristian.stoica@freescale.com>
Fri, 8 Aug 2014 09:30:04 +0000 (12:30 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 25 Aug 2014 12:32:32 +0000 (20:32 +0800)
The argument "req" of do_one_async_hash_op is not used by the
function. This patch removes this argument and renames the
function to match more closely its purpose.

Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/testmgr.c

index f217c62..f90e91c 100644 (file)
@@ -178,9 +178,7 @@ static void testmgr_free_buf(char *buf[XBUFSIZE])
                free_page((unsigned long)buf[i]);
 }
 
-static int do_one_async_hash_op(struct ahash_request *req,
-                               struct tcrypt_result *tr,
-                               int ret)
+static int wait_async_op(struct tcrypt_result *tr, int ret)
 {
        if (ret == -EINPROGRESS || ret == -EBUSY) {
                ret = wait_for_completion_interruptible(&tr->completion);
@@ -264,30 +262,26 @@ static int __test_hash(struct crypto_ahash *tfm, struct hash_testvec *template,
 
                ahash_request_set_crypt(req, sg, result, template[i].psize);
                if (use_digest) {
-                       ret = do_one_async_hash_op(req, &tresult,
-                                                  crypto_ahash_digest(req));
+                       ret = wait_async_op(&tresult, crypto_ahash_digest(req));
                        if (ret) {
                                pr_err("alg: hash: digest failed on test %d "
                                       "for %s: ret=%d\n", j, algo, -ret);
                                goto out;
                        }
                } else {
-                       ret = do_one_async_hash_op(req, &tresult,
-                                                  crypto_ahash_init(req));
+                       ret = wait_async_op(&tresult, crypto_ahash_init(req));
                        if (ret) {
                                pr_err("alt: hash: init failed on test %d "
                                       "for %s: ret=%d\n", j, algo, -ret);
                                goto out;
                        }
-                       ret = do_one_async_hash_op(req, &tresult,
-                                                  crypto_ahash_update(req));
+                       ret = wait_async_op(&tresult, crypto_ahash_update(req));
                        if (ret) {
                                pr_err("alt: hash: update failed on test %d "
                                       "for %s: ret=%d\n", j, algo, -ret);
                                goto out;
                        }
-                       ret = do_one_async_hash_op(req, &tresult,
-                                                  crypto_ahash_final(req));
+                       ret = wait_async_op(&tresult, crypto_ahash_final(req));
                        if (ret) {
                                pr_err("alt: hash: final failed on test %d "
                                       "for %s: ret=%d\n", j, algo, -ret);